Good coding style

Remarks

I would recommend to a beginner to start with this style of coding. And if anybody can suggest a better way(p.s i opted this technique and is working efficiently for me in an app used by more then 100k users), feel free for any suggestions. TIA.